Wire Telemetry metric views config to Beholder and LOOP plugins - #23085
Merged
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
pkcll
force-pushed
the
beholder-otel-limit-metric-cardinality
branch
from
July 13, 2026 17:46
af4fd5e to
a43c1b3
Compare
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
2 times, most recently
from
July 13, 2026 17:59
6098e68 to
b5f8fd9
Compare
pkcll
force-pushed
the
beholder-otel-limit-metric-cardinality
branch
from
July 13, 2026 18:00
331b2f2 to
724abfc
Compare
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
2 times, most recently
from
July 13, 2026 18:37
5f369f9 to
1a9e28e
Compare
pkcll
force-pushed
the
beholder-otel-limit-metric-cardinality
branch
from
July 13, 2026 18:39
107f0e8 to
3bbc6a1
Compare
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
from
July 13, 2026 18:39
1a9e28e to
ddcec5d
Compare
pkcll
changed the base branch from
beholder-otel-limit-metric-cardinality
to
develop
July 13, 2026 18:40
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
from
July 13, 2026 18:44
ddcec5d to
fae259e
Compare
Add MetricViewsDisabled and MetricViewsAttributeBlacklist to core.toml, forward through shell and loop registry, and bump chainlink-common to ff6c540906a9 for companion PR chainlink-common #2238. Co-authored-by: Cursor <cursoragent@cursor.com>
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
from
July 13, 2026 18:44
fae259e to
8768af3
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
from
July 13, 2026 19:14
0e14f8c to
bbb94f0
Compare
Drop MetricViewsDisabled; empty MetricViewsAttributeDenylist disables default views. Rename blacklist to denylist and bump chainlink-common to c2bb0f6d4. Co-authored-by: Cursor <cursoragent@cursor.com>
…l-metric-filter-views
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
from
July 17, 2026 00:19
a0ec95c to
de3c85c
Compare
…gin/develop - Merge origin/develop into beholder-otel-metric-filter-views - Resolve go.mod/go.sum conflicts keeping views branch chainlink-common - Bump chainlink-common to v0.11.2-0.20260720200433-dee51f29efab - Bump chainlink-common/pkg/chipingress to v0.0.11-0.20260716165322-7f2edff6e954 - Rename MetricViewsAttributeDenylist -> MetricViewsDenyAttributes to match the updated chainlink-common beholder.Config field name - Regenerate docs/CONFIG.md and test fixtures - Run make gomodtidy and make config-docs
pkcll
marked this pull request as ready for review
July 20, 2026 23:56
product-security-plaid-production
Bot
requested review from
justinkaseman and
kalverra
July 20, 2026 23:56
pkcll
requested review from
jmank88,
patrickhuie19 and
pavel-raykov
and removed request for
justinkaseman and
kalverra
July 21, 2026 00:20
pavel-raykov
previously approved these changes
Jul 21, 2026
pkcll
added a commit
that referenced
this pull request
Jul 24, 2026
Merge origin/develop into beholder-otel-metric-filter-views and resolve conflicts, keeping both MetricViewsDenyAttributes (from #23085) and MetricCardinalityLimit (from develop). The chainlink-common version is now v0.11.2-0.20260722120418-c1a1e0e75034, which includes the merged #2238. Also run make gomodtidy, make config-docs, and update testscript fixtures.
Merge origin/develop into beholder-otel-metric-filter-views, taking go.mod and go.sum files from develop and resolving source conflicts to keep both MetricViewsDenyAttributes (from #23085) and MetricCardinalityLimit (from develop). The chainlink-common version is v0.11.2-0.20260722120418-c1a1e0e75034, the newest of the merge commit for chainlink-common#2238 (c08ad805d9db) and the version already on develop. Also run make gomodtidy, make config-docs, and update testscript fixtures.
pkcll
force-pushed
the
beholder-otel-metric-filter-views
branch
from
July 24, 2026 21:58
9a51249 to
857d331
Compare
pkcll
enabled auto-merge
July 24, 2026 22:01
|
jmank88
approved these changes
Jul 24, 2026
pavel-raykov
approved these changes
Jul 27, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion to chainlink-common #2238, which has merged to
main.This PR wires the new Beholder metric-views denylist into the Chainlink node and LOOP plugin forwarding, while also merging latest
origin/develop.Changes
Telemetry.MetricViewsDenyAttributesconfig option (default["event_id"]). An empty list disables the default Beholder metric attribute deny views; there is no separate disabled flag.MetricViewsDenyAttributesthrough telemetry config accessors,shell.goBeholder client construction, and LOOP plugin env forwarding (plugins/loop_registry.go).origin/developand resolve conflicts, keeping bothMetricViewsDenyAttributes(from this PR) andMetricCardinalityLimit(from develop).chainlink-commontov0.11.2-0.20260722120418-c1a1e0e75034— the newest of thechainlink-common#2238merge commit (c08ad805d9db) and the version already ondevelop.docs/CONFIG.mdand update config golden fixtures (web resolver + txtar validate scripts).Test plan
go test ./core/services/chainlink/... ./plugins/...event_idis dropped from exported metrics with default config